Timestamp the runner log lines - #99
Merged
Merged
Conversation
Diagnosing the dogfood runner's 26-minute 'task listing failed' storm (348 lines from a transient DB lock) was guesswork because runner.log carried no timestamps at all. The runner process now configures WARNING+ logging with asctime — runner.log is the only forensic trail after a crash, and its lines must be placeable in time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while diagnosing the live dogfood runner: a 26-minute
task listing failed; will retry next passstorm (348 lines, transient SQLite lock contention during startup) leftrunner.logwith zero timestamps — the lines could not be placed in time relative to the check-observed activity in the database.The runner process now configures WARNING+ logging with
%(asctime)s. Process-local (basicConfigin our own CLI process, beforedaemon.serve); no global library policy is touched.