Repository navigation
skills: check artifacts and require extra self-review for large PRs - #105
Merged
Merged
Conversation
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
hsliuustc0106
marked this pull request as ready for review
October 6, 2026 14:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Require committed-artifact checks in System1-Omni reviews and prechecks, including quick checks. Shared guidance distinguishes maintained configuration, examples and replay/oracle fixtures from redundant run summaries, response dumps, cache/profiler output and process notes. Preserve raw measurements and failures in durable evidence or an immutable commit archive, and verify consumers, documentation links and replay commands before removing output.
Add contributor requirements for PRs with more than 3,000 changed lines of authored code: complete a full self-review, consider splitting independent changes, explain why a large change stays together with a component map and review order, and report validation for each affected component and interface. Count additions plus deletions in source, tests and build/validation scripts against the PR merge base, separately from total diff size. Documentation, generated output, lockfiles and static fixtures are excluded from this code count but still reviewed. Keep the PR in draft until contributor self-review is complete.
CONTRIBUTING.mddefines the large-change policy; the canonicalprecheck-pr,self-reviewandsystem1-omni-reviewskills apply it. Size triggers closer preparation and review, without implying a correctness defect or requiring expensive experiments by itself.Test Plan
System1-Omni Version / Commit: base
47eff9cdeda01e4847a4fb9634a43f2cab6a233f, headef9279638e54f2b3c82403b9fd3ba3a949cdfb99.Validate all three skill entrypoints with
quick_validate.py, resolve their shared artifact and large-change links/anchors, inspect the complete instruction diff, rungit diff --check, and build the documentation using the existing pinned docs environment. Check the size convention against #96. This PR changes contributor guidance and review instructions; runtime tests and GPU experiments are inapplicable.Test Result
quick_validate.pypassed forself-review,precheck-prandsystem1-omni-review.large-code-changesanchor.git diff --checkandpython -m mkdocs build --strictpassed.4927d2a3373ae3e2d825bf63a320178988540031, the Rust/CUDA/header sources and tests plus Python preparation/replay scripts account for 4,649 changed authored-code lines, out of 7,413 total changed text lines and one binary file. It exceeds the threshold after excluding fixtures, documentation, licenses and configuration.Demo / evidence
N/A for inference or performance measurements: this PR changes instructions and documentation. The concrete artifact cleanup is in #96, removing 30 generated run files and linking their immutable archive while preserving replay inputs and expected responses.
Self-review