Discover local serving models in fleet telemetry - #107
Merged
ThinkOffApp merged 1 commit intoSep 17, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discover model identities during the existing device publication rather than relying on stale manual labels. Probe local OpenAI-compatible servers and LM Studio's loaded-instance API, cache for a minute, and publish explicit nulls on unknown/empty results so PATCH clears old model names. Manual fallback is visibly labelled. Generic OpenAI IDs are advertised IDs, not proof of loaded weights.
Explicit server credentials come only from a server-specific file and are sent only to the configured origin; redirects and non-loopback plain HTTP are refused. No intent credential is forwarded. No additional GroupMind timer/request is created.
Validation: 57 tests pass, including loaded/unloaded LM Studio, multi-model IDs, auth failure clearing, manual fallback, successful empty results, caching/single-flight and credential destination checks. Built on PR #106; merge that first. Hardware rollout status is reported separately from these tests.