fix(process): recover from broken process pool - #95
Open
olivermeyer wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
olivermeyer
marked this pull request as ready for review
July 21, 2026 09:14
Author
|
Hi @TkTech any chance you take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94.
Why?
When a subprocess dies abruptly (via
os._exit(), a signal, OOM, or an exception that can't be pickled back to the parent),concurrent.futuresmarks the pool as broken and raisesBrokenProcessPoolon every subsequentsubmit()call. This exception escapedProcessExecutor.push()into the worker's job-pull loop, killing the entire worker — triggering crash-restart loops under a supervisor and unboundedmax_attemptsinflation via the Recovery plugin.How?
Pool construction is extracted into a
_create_pool()helper. Inpush(), thepool.submit()call is wrapped in atry/except BrokenProcessPool: on failure the broken pool is replaced with a fresh one (old.shutdown(wait=False)), and the submit is retried once. If the retry also raises, the job is routed throughon_job_completed(exc=...)inline so it fails/retries per its ownmax_attemptswithoutBrokenProcessPoolever reaching the worker loop. A defensivepids_for_job.pop()is added to_on_job_completedto clean up entries left by processes that died before theirfinallyblock ran.