新增插件 辅助用户循环签到#159
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
Jul 2, 2026 2:51p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
|
|
😭 |
这一部分代码我想提出一点修改建议:
1.密码哈希我想你应该做成全局变量,这样可以提高一些效率。毕竟每一个请求都要哈希一次有点浪费资源了。
2.请求登录nv1可以只登录一次后保存重复使用，当然也要做好失效的检测。这样做对于nv1和玩家是友好的。
|
|
还有，requests本身带有.json()方法转化成json。如果你想统一处理可以把请求单独封装成一个函数，让他做处理 |
| name = "辅助用户循环签到" | ||
| author = "丸山彩" | ||
| version = (0, 0, 1) | ||
|
|
There was a problem hiding this comment.
| url = "https://nv1.nethard.pro/api/" | |
|
|
||
| login_url = "https://nv1.nethard.pro/api/user/login" | ||
| sign_url = "https://nv1.nethard.pro/api/helper-bot/daily-sign" | ||
|
|
There was a problem hiding this comment.
| login_url = "https://nv1.nethard.pro/api/user/login" | |
| sign_url = "https://nv1.nethard.pro/api/helper-bot/daily-sign" |
| Print.print_err(f"[{self.name}] 登录失败：{msg}") | ||
| return | ||
|
|
||
| r2 = sess.get(sign_url, headers=headers, timeout=timeout_f) |
There was a problem hiding this comment.
| r2 = sess.get(sign_url, headers=headers, timeout=timeout_f) | |
| r2 = sess.get(f"{self.url}helper-bot/daily-sign", headers=headers, timeout=timeout_f) |
There was a problem hiding this comment.
f"{self.url}helper-bot/daily-sign" or f"{self.url}/helper-bot/daily-sign"?
There was a problem hiding this comment.
f"{self.url}helper-bot/daily-sign"orf"{self.url}/helper-bot/daily-sign"?
我前面url有后面的/了,所有只能用f"{self.url}helper-bot/daily-sign"
|
插件目前最终完成了吗？本 PR 已超时太久了。 |
Removed the _logged_in variable from the login logic to simplify state management.
是完成的 |
4 participants
NV1 辅助用户循环签到，用于给机器人涨经验值