test: optional title migration contract / 可选参数迁移验收 - #103
Merged
Merged
Conversation
8 tasks
Member
Author
中文已自行 review 当前 HEAD beaa83d:生产定义/依赖没有变动,JS 宿主直接运行 Calcit :tests,临时 snapshot 使用独立模块链接且 finally 清理;非法参数检查同时要求退出码和类型诊断。原有 90 个 native 测试保留,新增 5 个测试由独立 JS CI 覆盖。精确 HEAD CI 已成功,当前没有未处理评论。 EnglishSelf-reviewed HEAD beaa83d: no production definition/dependency changes; JS executes Calcit definition tests from an isolated temporary Snapshot with finally cleanup. Negative checks require both failure status and a type diagnostic. All 90 existing native tests remain covered, and five new tests run in the JS CI step. Exact-head CI passed; no outstanding comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文
补齐 calcit-lang/calcit#1286 的真实旧可选参数迁移验收。生产迁移已经在 #101 合并,本 PR 不修改生产函数或依赖。
comp-title :tests中增加 5 个 Calcit 测试:尾部省略、显式 None、回调/子组件单次求值、每次点击一次回调,以及旧 nil/false 空回调行为。验证:Calcit / @calcit/procs 0.22.1、Node 24;5 个 JS Calcit 测试和 3 个非法参数检查通过;client 14、server 90 测试通过;compile-page、release-page、dayjs adapter、session messages、typed database 检查通过;格式化无变化、git diff --check 通过。Vite 仍提示 bundle 大小警告。
English
Complete the bounded legacy optional-parameter acceptance example for calcit-lang/calcit#1286. Production migration already landed in #101; this PR changes neither production functions nor dependencies.
Validation with Calcit / @calcit/procs 0.22.1 and Node 24: 5 JS Calcit tests, 3 invalid-argument checks, 14 client and 90 server tests pass; browser compile/build and dayjs/session-message/typed-database regressions pass. Canonical format unchanged and diff check clean. Existing bundle-size warning remains.