Conversation
Areloch
commented
Sep 26, 2026
Contributor
- Fix the check for the World Editor guis in the CMakeLists so that it doesn't erroneously shove it into a /source subfolder in the solution
- Add a check during asset import that if the config normally always forces a material suffix, we do a check without the suffix to see if we have a match too, so we don't erroneously duplicate a material that actually already exists
- Fix the item testbox's max extent
- Make the mBackground in the guiPopUp classes be a SimObjectPtr to manage the object ref a little more sanely
- In the event another canvas is made, added sanity check to avoid erroneously re-processing the SFX system, which could cause a crash
- Fixed TypeMatrixF to properly set and get the full matrix value
- Added helper functions to fully copy the aiNodeAnim and aiMeshAnim classes as they don't have copy constructors, so when processing data in AssimpAppSequence, the copying of the data could leave room for incomplete/shallow copies, or hanging memory. The util functions do a full clone copy, so there's no hanger-ons with the memory, and is safe to clean up at any time
- Associated to above, but also expressly added cleanup to that data
- in TSShape's initMaterialList and buildConvexHull, added + start so the end range is properly offset
- Fix the check for the World Editor guis in the CMakeLists so that it doesn't erroneously shove it into a /source subfolder in the solution - Add a check during asset import that if the config normally always forces a material suffix, we do a check without the suffix to see if we have a match too, so we don't erroneously duplicate a material that actually already exists - Fix the item testbox's max extent - Make the mBackground in the guiPopUp classes be a SimObjectPtr to manage the object ref a little more sanely - In the event another canvas is made, added sanity check to avoid erroneously re-processing the SFX system, which could cause a crash - Fixed TypeMatrixF to properly set and get the full matrix value - Added helper functions to fully copy the aiNodeAnim and aiMeshAnim classes as they don't have copy constructors, so when processing data in AssimpAppSequence, the copying of the data could leave room for incomplete/shallow copies, or hanging memory. The util functions do a full clone copy, so there's no hanger-ons with the memory, and is safe to clean up at any time - Associated to above, but also expressly added cleanup to that data - in TSShape's initMaterialList and buildConvexHull, added + start so the end range is properly offset
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.