Skip to content

Show the notification permission prompt on every tab #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasnder merged 1 commit into from
Aug 5, 2026
Merged

Show the notification permission prompt on every tab #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions app/src/main/res/layout/main.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,26 @@
app:titleTextColor="@android:color/white" />
</com.google.android.material.appbar.AppBarLayout>

<!--
Outside llApps on purpose: that container is hidden on the Timeline and
VPN tabs, and Timeline is where the app lands. A prompt to grant a
permission has to be visible whichever tab the user is on.
-->
<TextView
android:id="@+id/tvNotifications"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:drawableStart="@drawable/twotone_notifications_24"
android:drawablePadding="8dp"
android:drawableTint="?attr/colorError"
android:padding="8dp"
android:paddingStart="@dimen/activity_horizontal_margin"
android:paddingEnd="@dimen/activity_horizontal_margin"
android:text="@string/msg_notifications"
android:textAppearance="@style/TextSmall"
android:textColor="?attr/colorOff"
android:visibility="gone" />

<FrameLayout
android:layout_width="match_parent"
android:layout_height="0dp"
Expand Down Expand Up @@ -60,19 +80,6 @@
android:visibility="gone" />
</LinearLayout>

<TextView
android:id="@+id/tvNotifications"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:drawableStart="@drawable/twotone_notifications_24"
android:drawablePadding="8dp"
android:drawableTint="?attr/colorError"
android:padding="8dp"
android:text="@string/msg_notifications"
android:textAppearance="@style/TextSmall"
android:textColor="?attr/colorOff"
android:visibility="visible" />

<androidx.swiperefreshlayout.widget.SwipeRefreshLayout
android:id="@+id/swipeRefresh"
android:layout_width="match_parent"
Expand Down