fix(demo): make News Sources configurable - #755
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
luokerenx4
marked this pull request as ready for review
July 29, 2026 05:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/api/configresponse/api/config/newsmutation handler so enablement, intervals, feed toggles, additions, and removals round-trip during a demo sessionWhy
The News Sources route used
useConfigPage, but the demo config response omitted the entirenewssection and had no matching PUT handler. The page therefore rendered an empty fallback form, then silently discarded every attempted change: adding a feed cleared the form but left the list empty.User impact
The public demo now presents a realistic enabled/paused RSS pair and lets users exercise the full News Collector configuration flow. Changes remain available for the current demo session while still following the demo banner's non-persistent contract.
Validation
pnpm vitest run ui/src/demo/handlers/configNews.spec.ts ui/src/demo/handlers/configKeys.spec.ts(2 files, 4 tests passed)git diff --checknpx tsc --noEmitcd ui && npx tsc -bpnpm test(358 passed, 1 skipped files; 3391 passed, 9 skipped tests)pnpm -F open-alice-ui build:demoExample MarketsproducedSavedand a stable2 of 3 feeds activelistNo external RSS fetch was run because this changes only the deterministic demo configuration contract, not the production collector or network parser.