Validate RSS feed URLs before saving - #756
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The production news configuration schema requires
z.string().url(), but the UI previously checked only that the field was non-empty. Values such asnot-a-urlenabled Add Feed and were rejected only after the request reached the server, without any field-level explanation.User impact
Users now get immediate, actionable feedback while entering a feed URL. A valid URL clears the error and enables submission, so the UI contract matches the production validation boundary.
Verification
pnpm exec vitest run ui/src/pages/NewsCollectorPage.spec.tsx— 2 passednpx tsc --noEmitcd ui && npx tsc -bpnpm -F open-alice-ui build:demopnpm test— 3390 passed, 9 skipped/settings/news-collector): verifiednot-a-urlshows the inline alert and keeps Add Feed disabled; replacing it withhttps://example.com/rss.xmlclears the alert and enables the buttongit diff --check