Enforce valid order sizing in manual entry - #763
Draft
luokerenx4 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The form claimed Cash Qty would override Quantity, but retained both values and sent both fields. UTA explicitly rejects
totalQuantity + cashQtyas mutually exclusive. The form also allowed a Limit order to use Cash Qty even though UTA supports notional sizing only for Market orders.Verification
pnpm vitest run ui/src/components/uta/OrderEntryDialog.spec.tsxnpx tsc --noEmitcd ui && npx tsc -bpnpm test(358 passed, 1 skipped; 3391 tests passed, 9 skipped)git diff --check1+ Cash Qty100with submit enabled before the fix; after the fix, entering Cash Qty clears Quantity, and switching to Limit removes Cash Qty and disables submit until valid Limit sizing is suppliedBoundary touch