Confirm destructive Inbox deletion - #765
Draft
luokerenx4 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
A real Demo walkthrough showed that one click on the Inbox trash icon immediately removed the selected update and advanced to the next entry. The page-level Delete/Backspace shortcut had the same behavior. Inbox entries are durable delivery records that can carry attachments, replies, sender Session identity, and provenance, so an accidental keypress or icon click should not issue a hard delete without confirming intent.
User impact
Both mouse and keyboard deletion now pause at the same clear, localized confirmation. Cancelling leaves the entry selected and untouched; only the destructive confirmation calls the delete API.
Verification
pnpm vitest run ui/src/pages/InboxPage.spec.tsx— 3 tests passednpx tsc --noEmitcd ui && npx tsc -bpnpm test— 357 files passed, 1 skipped; 3389 tests passed, 9 skippedpnpm -F open-alice-ui build:demopnpm -F open-alice-ui dev:demobrowser walkthrough: