Skip to content

Confirm destructive Inbox deletion - #765

Draft
luokerenx4 wants to merge 1 commit into
devfrom
codex/confirm-inbox-delete
Draft

Confirm destructive Inbox deletion#765
luokerenx4 wants to merge 1 commit into
devfrom
codex/confirm-inbox-delete

Conversation

@luokerenx4

Copy link
Copy Markdown
Contributor

What changed

  • route the Inbox trash button through a confirmation dialog before hard deletion
  • make the page-level Delete and Backspace shortcuts open the same confirmation instead of deleting immediately
  • explain that the Inbox update is removed permanently while linked Workspace files remain intact
  • localize the confirmation copy and cancel action in English, Simplified Chinese, Traditional Chinese, and Japanese
  • add an integration test covering button confirmation, cancellation, keyboard confirmation, and the eventual API call

Why

A real Demo walkthrough showed that one click on the Inbox trash icon immediately removed the selected update and advanced to the next entry. The page-level Delete/Backspace shortcut had the same behavior. Inbox entries are durable delivery records that can carry attachments, replies, sender Session identity, and provenance, so an accidental keypress or icon click should not issue a hard delete without confirming intent.

User impact

Both mouse and keyboard deletion now pause at the same clear, localized confirmation. Cancelling leaves the entry selected and untouched; only the destructive confirmation calls the delete API.

Verification

  • pnpm vitest run ui/src/pages/InboxPage.spec.tsx — 3 tests passed
  • npx tsc --noEmit
  • cd ui && npx tsc -b
  • pnpm test — 357 files passed, 1 skipped; 3389 tests passed, 9 skipped
  • pnpm -F open-alice-ui build:demo
  • real pnpm -F open-alice-ui dev:demo browser walkthrough:
    • clicked the Inbox trash action and confirmed the dialog appears without advancing selection
    • cancelled and confirmed the original entry remains selected
    • pressed Backspace and confirmed the same dialog appears
    • confirmed deletion and verified the dialog closes and selection advances to the next entry

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openalice-demo Ready Ready Preview, Comment Jul 28, 2026 10:20pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant