Skip to content

Confirm AI credential deletion - #766

Merged
luokerenx4 merged 1 commit into
devfrom
codex/confirm-credential-delete
Jul 29, 2026
Merged

Confirm AI credential deletion#766
luokerenx4 merged 1 commit into
devfrom
codex/confirm-credential-delete

Conversation

@luokerenx4

Copy link
Copy Markdown
Contributor

Summary

  • give each AI credential delete action a contextual accessible name
  • require confirmation before removing a stored credential
  • explain that deletion also clears new Workspace defaults while leaving existing Workspace files unchanged
  • keep the confirmation open when deletion fails
  • localize the new flow in English, Simplified Chinese, Traditional Chinese, and Japanese

Why

A real Settings → AI Provider walkthrough showed that credential deletion happened immediately with no confirmation. The backend also prunes any new-Workspace credential defaults that reference the deleted slug, so the action has a wider effect than the UI disclosed.

Verification

  • pnpm vitest run ui/src/pages/AIProviderPage.spec.tsx (4 passed)
  • npx tsc --noEmit
  • cd ui && npx tsc -b
  • pnpm test (357 files passed, 1 skipped; 3390 tests passed, 9 skipped)
  • pnpm -F open-alice-ui build:demo
  • real demo walkthrough: contextual delete names, confirmation content, cancel path, confirm path, and selected OpenAI default verified

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openalice-demo Ready Ready Preview, Comment Jul 28, 2026 10:27pm

Request Review

@luokerenx4 luokerenx4 added area:settings Settings, configuration, credentials, or permissions review:deep Requires deliberate human review before merge theme:safety Correctness, validation, destructive-action, or trading safety workflow:parallel Autonomous parallel contribution; leave open for later acceptance labels Jul 29, 2026 — with ChatGPT Codex Connector
@luokerenx4
luokerenx4 merged commit 72f7e09 into dev Jul 29, 2026
7 checks passed
@luokerenx4
luokerenx4 deleted the codex/confirm-credential-delete branch July 29, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:settings Settings, configuration, credentials, or permissions review:deep Requires deliberate human review before merge theme:safety Correctness, validation, destructive-action, or trading safety workflow:parallel Autonomous parallel contribution; leave open for later acceptance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant