Prevent position closes from crossing through flat - #768
Draft
luokerenx4 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
On the Demo Portfolio account, AAPL showed an open quantity of 120. The close dialog accepted
200with a commit message and enabled Close Position; the Demo backend only rejected it later because Demo mutations are read-only. Alpaca and IBKR adapters build an explicit reverse market order for the supplied quantity, so an oversized close can cross through flat into a new opposite exposure.Verification
pnpm vitest run ui/src/components/uta/OrderEntryDialog.spec.tsx services/uta/src/domain/trading/UnifiedTradingAccount.spec.ts(116 passed)npx tsc --noEmitcd ui && npx tsc -bpnpm test(3397 passed, 9 skipped)pnpm test:e2e(30 passed, 3 skipped)No live-paper order was sent: this is a broker-independent pre-dispatch safety boundary, and the MockBroker lifecycle verifies that rejected operations never reach
broker.closePosition.