Skip to content

Identify each position close action by contract - #769

Draft
luokerenx4 wants to merge 1 commit into
devfrom
codex/label-position-close-actions
Draft

Identify each position close action by contract#769
luokerenx4 wants to merge 1 commit into
devfrom
codex/label-position-close-actions

Conversation

@luokerenx4

Copy link
Copy Markdown
Contributor

Summary

  • give the positions table action column an accessible Actions heading
  • name each close button with the contract's canonical display label while keeping the visible text concise
  • cover the column name, per-contract button names, and click routing with a focused component test

Evidence

The Demo Portfolio page showed four open positions (AAPL, NVDA, GOOG, AMD), but its accessibility tree exposed four indistinguishable buttons all named only Close, and the action column had no heading. Keyboard and screen-reader users could not tell which position each action would close without reconstructing table position manually.

Verification

  • pnpm vitest run ui/src/pages/UTADetailPage.positions.spec.tsx (1 passed)
  • cd ui && npx tsc -b
  • npx tsc --noEmit
  • pnpm test (3389 passed, 9 skipped)
  • real Demo route: action column exposes Actions; buttons expose Close AAPL position, Close NVDA position, Close GOOG position, and Close AMD position; visible button text remains Close

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openalice-demo Ready Ready Preview, Comment Jul 28, 2026 10:59pm

Request Review

@luokerenx4 luokerenx4 added area:trading UTA, orders, positions, portfolio, or trading review theme:accessibility Keyboard, assistive technology, or interaction semantics workflow:parallel Autonomous parallel contribution; leave open for later acceptance labels Jul 29, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:trading UTA, orders, positions, portfolio, or trading review theme:accessibility Keyboard, assistive technology, or interaction semantics workflow:parallel Autonomous parallel contribution; leave open for later acceptance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant