Localize the file viewer return action - #772
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
On the Simplified Chinese Demo path
Tracked → stock-vst → power_buy_points_2026-06-02.md, the file viewer still rendered the English wordBack. Its accessible name was also onlyBack, even though the action does not return to the previous page: it opens the file's owning Workspace. The destination existed only in a mouse tooltip.The stale
demo-ws-1backlink identity visible on that route is already owned by open PR #749 and is intentionally not duplicated here. Once #749 lands, this button's target label will automatically use that corrected Workspace tag.Verification
pnpm vitest run ui/src/pages/FileViewerPage.spec.tsx(2 passed)cd ui && npx tsc -bnpx tsc --noEmitpnpm test(3388 passed, 9 skipped)pnpm -F open-alice-ui build:demo返回; accessible name and tooltip are返回 demo-ws-on the current dev fixture