Name Session sidebar actions for their targets - #774
Draft
luokerenx4 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
In a Workspace with multiple Sessions, every row exposed the same accessible action names:
Stop this session,Resume this session, andDelete this session. The running Chinese demo reproduced the same ambiguity across several rows, so keyboard and screen-reader users could not tell which Session a lifecycle or destructive action would affect.User impact
Session actions are now self-identifying, for example
Stop Inspect the flooror删除“Build a thesis on NVDA”, while the existing icons, layout, and behavior remain unchanged.Validation
pnpm exec vitest run ui/src/components/workspace/Sidebar.spec.tsxcd ui && npx tsc -bnpx tsc --noEmitpnpm test(357 files passed, 1 skipped; 3389 tests passed, 9 skipped)pnpm -F open-alice-ui build:demo