Expose selected Settings controls - #776
Draft
luokerenx4 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
aria-pressedWhy
A real walkthrough of the Chinese demo Settings page showed that both selections were communicated only through color. Screen-reader users could activate the controls, but could not determine the current Settings view or language.
User impact
The selected Settings view and language are now announced consistently while the visual design and click behavior remain unchanged.
Validation
pnpm exec vitest run ui/src/pages/SettingsPage.selection-state.spec.tsx— 2 tests passednpx tsc --noEmitcd ui && npx tsc -bpnpm test— 358 files passed, 1 skipped; 3390 tests passed, 9 skippedpnpm -F open-alice-ui build:demo