Repository navigation
build: update Node.js to v26 and pnpm to v12 - #48
Merged
Merged
Conversation
Pin Node.js 26.10.0 in `.tool-versions` and make every CI job read it. The unit job also runs on Node.js 22, the floor of `engines`, which stays as it is, and `@types/node` goes back to `^22` to match that floor.
Coverage Report for CI Build 37503015236Coverage remained the same at 93.859%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
Pin pnpm 12.9.1 and ask CI for pnpm 12. Settings need no migration from pnpm 11. The lockfile records `linkDirectory: false` of the 11 packages that set it, which a frozen install of pnpm 12 checks, and pnpm 12 finds it up to date with that alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The repository was developed on Node.js 24.20.0 and pnpm 11.9.0, and CI ran on Node.js 24 alone, so nothing checked the floor of
engines.node,>=22. Node.js 26 is the latest release line and becomes an LTS on 2026-10-28, while the packages keep supporting Node.js 22 until its end of life on 2027-04-30.pnpm 12 is the latest release, and its breaking changes leave the workspace alone: pnpm 12 recognizes every setting of
pnpm-workspace.yaml, nothing passes--frozen-lockfile false, no dependency comes from git, andengineStrictis off. The one change it asks for is in the lockfile: pnpm 12, like pnpm 11.28, compares thepublishConfig.linkDirectoryof a package with the lockfile, so a frozen install of the old lockfile fails withERR_PNPM_OUTDATED_LOCKFILE. That is also why #47 pinned CI to pnpm 11.9.0.What
.tool-versionspins Node.js 26.10.0, the latest 26, and pnpm 12.9.1, the version of thelatesttag. Everyactions/setup-nodestep reads Node.js throughnode-version-file, so a bump of the file moves local development and CI together, and everypnpm/action-setupstep asks for pnpm 12 instead of the 11.9.0 pinned in build: limit concurrency of workspace scripts to CPU cores #47.unitjob runs on a matrix of Node.js 22, the floor the packages declare, and the version of.tool-versions, and uploads coverage from the latter alone.@types/nodegoes from^24back to^22, the floor, in the root and the 7 packages that use it, so the types catch an API of a newer Node.js. chore(deps): update dependency @types/node to v24 #32 had moved it to^24.@types/node24.13.3 to 22.20.1, which it already held, and re-keys the peer variants that take@types/node. The re-resolution also records the optional platform packages ofsatteri0.10.5, which the old lockfile missed. On top, it recordslinkDirectory: falsefor the 11 packages whosepublishConfigsets it, the way pnpm 12 writes it. No other version changes.Notes
engines.nodestays>=22in the packages and the root, so nothing gets released.@types/node, so it is going to offer^24again, as in chore(deps): update dependency @types/node to v24 #32.unitcheck now reports asunit (22)andunit (.tool-versions). No branch protection or ruleset requires the old name.minimumReleaseAgehas applied since pnpm 11, so the move to 12 changes nothing about it, andminimumReleaseAgeExcludestays as it is.@types/nodepass on^22, the unit tests of core and cli pass on Node.js 26 and 22, lint of core and cli passes, size-limit of imgproxy measures the same 806 B as on Node.js 24, on pnpm 12 the build of runtime throughpnpm runtriggers no install before the script, andlint-package-jsonpasses throughpnpm dlxon both versions of pnpm.