Repository navigation
fix(trogonstack-eventmodeling): split read models by shape, not by consumer - #106
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…nsumer Signed-off-by: Erik Nilsen <enilsen16@live.com>
4ca0d3a to
7c4cbf9
Compare
PR SummaryLow Risk Overview Command decision state (not a read model): Renames Command State Read Model to Command Decision State across designing and validating skills. The text now states this state is folded inside the handler, is not drawn on the board as a read model, and the rule stays: one decision state per command, never shared. Query read models — split by shape: Adds guidance to add read models only when fields, key, or source events differ; UI and processors that need the same data share one projection. Duplicate models with the same events and fields should be merged. The validating skill adds a No Duplicate Read Models check; slicing patterns note preferring a shared read model when consumers read the same shape. Reviewed by Cursor Bugbot for commit 7c4cbf9. Bugbot is set up for automated code reviews on this repo. Configure here. |
Summary
The event-modeling skills call command decision state a "read model" and say to never share read models between commands. Agents read this as "add one board read model per command", so models get far too many read models.
This change:
Test plan
node scripts/validate-plugins.mjsNeed help on this PR? Tag
@codesmith-botwith what you need.