Repository navigation
test(config): stop losing notifications during the idle ping - #15
Conversation
yordis
commented
Sep 15, 2026
- Postgrex drops a notification that arrives while the notifications connection is running its idle ping, and that is only fixed on Postgrex main (Fix notifications lost during idle ping elixir-ecto/postgrex#795), so no released version protects us
- A 100ms ping cadence turned that window into a lost append roughly once every 15 runs of the subscription tests, which is why CI failed at random with an empty mailbox and no log output to point at
- No other test environment sets an idle interval, and neither of the two reconnect tests that motivated it needs one
Postgrex drops a notification that arrives while the notifications connection is running its idle ping, and that is fixed only on Postgrex main (elixir-ecto/postgrex#795). A 100ms cadence turned that window into a failure roughly once every 15 runs of the subscription tests, which is why CI failed at random with no log output to point at. No other test environment sets it. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe test event-store configuration removes the explicit ChangesTest event-store configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The test configuration now avoids the frequent idle ping that caused intermittent notification delivery failures. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the store at night Comment |
PR SummaryLow Risk Overview That ping overlapped with a Postgrex bug where notifications arriving during the idle check can be dropped (fix only on unreleased main), which caused intermittent subscription test failures—empty mailboxes with no useful logs—about once every ~15 runs in CI. Other test stores and reconnect tests did not need this setting. Reviewed by Cursor Bugbot for commit 6f00234. Bugbot is set up for automated code reviews on this repo. Configure here. |