Repository navigation
feat!: accept only canonical UUIDs and drop Normalize - #12
Merged
Merged
Conversation
Signed-off-by: Erik Nilsen <enilsen16@live.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
enilsen16
marked this pull request as ready for review
October 22, 2026 14:51
Signed-off-by: Erik Nilsen <enilsen16@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidateUUIDaccepts only the canonical form: 36 characters, lowercase and hyphenated. It rejects upper case, URN, brace and unhyphenated forms. One UUID can then never be two different IDs, which is the TypeID spec rule.Definition.NormalizeandNormalizeUUIDare removed. The Elixir package has no matching option: itscastreturnsparse/1unchanged, andvalidate: :uuidkeeps the value as given.Validateis again the only hook, the same name as in Elixir.This is a breaking change before v1. Callers that receive other UUID forms convert them before
New, for example withuuid.Parse(s)and then.String(). The matching Elixir change is to makevalidate: :uuidaccept only the canonical form too.#11 needs to merge first, so this releases as 0.3.0 and not 1.0.0.
Tests
TestValidateUUIDcovers the canonical form and each rejected form. The existing decoder tests already check thatParse,FromStorage,Scanand JSON returnErrInvalidUUID. TheNormalizetests and example are removed.Need help on this PR? Tag
@codesmith-botwith what you need.