Repository navigation
feat: add objectidtest for deterministic IDs in tests - #6
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
enilsen16
added this pull request to stack #9
October 22, 2026 14:17
enilsen16
force-pushed
the
feat/objectidtest
branch
from
October 22, 2026 16:08
e2ba276 to
88a50af
Compare
Signed-off-by: Erik Nilsen <enilsen16@live.com>
enilsen16
force-pushed
the
feat/objectidtest
branch
from
October 22, 2026 16:19
88a50af to
ffcb77e
Compare
enilsen16
marked this pull request as ready for review
October 22, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5.
Summary
Package
objectidtestbuilds deterministic IDs for tests:FromSeed[T](seed)returns the ID whose bare value is the UUIDv5 ofseedin the packageNamespace. It panics if the type rejects the value.FromSeedIn[T](namespace, seed)takes another namespace, to match IDs that another service's test helpers derive, such as umbrella'sTestSupport.fan_id(seed).A test can then name "the buyer" and get the same valid ID on every run, without hard-coded UUIDs.
Tests
The tests check that the same seed gives the same ID, different seeds give different IDs, the bare value is a UUIDv5, and an integer type panics.
ExampleFromSeedis included. CI runs only on PRs tomain. Locally,go test -race,go vetand golangci-lint pass.Need help on this PR? Tag
@codesmith-botwith what you need.