Repository navigation
Conversation
yordis
commented
Oct 23, 2026
- Bucket notifications were ignored whenever the store is configured with a prefix, so the bridge only caught up on the periodic sweep.
- Brings in Resolve a {"repo": …} events notify under a store prefix tobi/walgit#105 by jilio, cherry-picked with original authorship; the upstream test fails on our main and passes with this change.
PR SummaryLow Risk Overview
Integration tests wrap the in-memory store with Reviewed by Cursor Bugbot for commit 7effbc2. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7effbc2 to
af2f57f
Compare
59cd364 to
17f6375
Compare
POST /_events/notify turns a plain {"repo": "o/r"} into the key
repos/o/r/manifest.pb and resolves it like a bucket notification, which
must start with store.prefix. With a non-empty prefix the key never
matches: the notify is acked with an empty report and the bridge waits
for its sweep (default 5 min), silently. Bucket notifications are fine:
they carry the prefixed object key.
Build the key the repository's manifest has in this bucket, prefix
included. Keys in bucket notifications and {"key": …} stay bucket object
keys; EVENTS.md now says so.
The test harness now applies store.prefix the way
walgit_store::from_config does for real backends, so a server test can
run under a prefix. notify_wakes_the_bridge_under_a_store_prefix sends
all four shapes to a prefixed server (before: {"repo": "t/r"} answered
[] and woke nothing); the bridge unit test resolves them under a prefix.
(cherry picked from commit 9a24f26)
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
af2f57f to
eb5ed5e
Compare
f04e68a
into
yordis/fix-wal-create-existing-repo-409