Skip to content

Upgraded to Node 26.11.1 - #991

Open
EvanHahn wants to merge 1 commit into
mainfrom
node26
Open

EvanHahn wants to merge 1 commit into
mainfrom
node26

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

no ref

No user impact expected.

This is deployed with Docker so I think this is a backwards-compatible change, and no major version bump is required.

I think this is a useful change on its own (Node 22 will be EOL in April 2027) but also makes an upcoming change slightly easier.

no ref

No user impact expected.

This is deployed with Docker so I think this is a backwards-compatible
change, and no major version bump is required.
@EvanHahn
EvanHahn requested a review from cmraible as a code owner October 13, 2026 15:55
@EvanHahn
EvanHahn added this pull request to stack #994 October 13, 2026 15:55
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: e9c45a5a-b2c7-4e25-a0c5-b139a1d06faf
📥 Commits

Reviewing files that changed from the base of the PR and between b47cdd7 and b05d29b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • .github/workflows/ci.yml
  • .nvmrc
  • Dockerfile
  • README.md
  • docs/deployment.md
  • package.json

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The project now specifies Node.js 26 in its version configuration, package engine requirement, Docker build, and development prerequisites. The Docker build installs and enables Corepack 0.36.0. CI no longer uses a Node-version matrix and uses the extracted Node version for its Docker build. Coverage and image steps no longer have matrix-leg conditions. The deployment documentation describes the single-version CI process and retains the GHCR cache push.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: cmraible

Merge Risk: ⚪ Minimal · up to b05d2

The Node 26 update is reflected across the project prerequisites, Docker build, and CI workflow. No actionable user-facing or operational risk is identified.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description explains the Node.js upgrade, expected user impact, compatibility assessment, and motivation for the change. It is related to the changeset.
Title check Passed The title clearly and concisely identifies the main change: upgrading the project to Node.js 26.11.1.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b47cdd7). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage        ?   95.97%           
=======================================
  Files           ?       49           
  Lines           ?     1167           
  Branches        ?      201           
=======================================
  Hits            ?     1120           
  Misses          ?       47           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn
EvanHahn requested review from cmraible and removed request for cmraible October 13, 2026 15:59
@cmraible

Copy link
Copy Markdown
Collaborator

Gonna deploy this baby to staging for a bit to see if anything unexpected breaks

@github-actions

Copy link
Copy Markdown

✅ Deployed to staging (tree: e07a55222374c0cae4cecece440a8d59b13611a7)

@cmraible

Copy link
Copy Markdown
Collaborator

Looks good in staging. Planning to merge this in the morning so we can keep an eye on it throughout the day

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants