refactor(profiler): remove commented-out single-thread AdvancedProfiler#58
Merged
Merged
Conversation
~160 lines of a fully commented-out single-thread variant of AdvancedProfiler were left dead in the file; git history is the right place for it, not the source tree. Note: get_synthetic_latency() in message_data.py (the other item in issue #50) is left untouched here — removing it would change the CSV schema and break scripts/server/evaluations/edit_evaluations.ipynb, which reads the synthetic_latency column, so that needs its own follow-up. Partially addresses #50
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdvancedProfilerinsrc/server/core/profiler.py. It's dead code left over from an earlier iteration — the version history is preserved in git, not needed in the source tree.get_synthetic_latency()inmessage_data.py) is intentionally left untouched here — removing it would change the CSV schema and breaksrc/server/evaluations/edit_evaluations.ipynb, which reads thesynthetic_latencycolumn. That needs its own scoped follow-up rather than a blind removal.Test plan
tests/unit/test_profiler_source.py::test_profiler_has_no_leftover_commented_out_class, verified it fails before the removal and passes after.uv run python -c "from server.core.profiler import AdvancedProfiler"— module still imports cleanly./fast-tests) — 177 passed, 1 skipped