Remove unfinished get_synthetic_latency placeholder#59
Open
ff225 wants to merge 1 commit into
Open
Conversation
get_synthetic_latency() always returned 1 and was only ever multiplied into get_avg_speed's latency term, making it a no-op. Drop it instead of finishing the implementation since no intended semantics were documented anywhere. Closes #50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessageData.get_synthetic_latency()always returned1and was multiplied intoget_avg_speed's latency term — a no-op placeholder that was never completed.synthetic_latencyclass attribute, and the now-unnecessary parameter fromget_avg_speed, updating the one call site inrequest_handler.py.Test plan
tests/unit/test_message_data.pycoverage: placeholder attributes are gone,get_avg_speedstill computespayload_size / latencyand returns 0 on zero latency.uv run pytest tests/unit -k "message_data or request_handler"passes (17 passed, 1 skipped).Closes #50