Remove unimplemented get_synthetic_latency placeholder#64
Open
ff225 wants to merge 1 commit into
Open
Conversation
It always returned 1, was never completed, and only served as a no-op multiplier in get_avg_speed. Drop the field and the multiplication rather than complete a never-specified behavior.
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdvancedProfilerblock inprofiler.py— no longer exists onmain; it appears to have already been cleaned up in an earlier change, so nothing to do there).MessageData.get_synthetic_latency()was a placeholder that always returned1and was never completed. It only ever multipliedlatencyby1insideget_avg_speed, so removing it changes no runtime behavior.synthetic_latencyclass attribute,get_synthetic_latency(), and the corresponding parameter fromget_avg_speed. Updated the one call site inrequest_handler.py::_extend_message_data.Test plan
tests/unit/test_message_data.pycoveringget_avg_speed(including zero-latency) and confirming the placeholder is gone.uv run pytest tests/unit/test_message_data.py -q— 5 passedtests/unit, integration subset, mqtt, offloading_algo) — 187 passed, 1 skipped, no regressionsCloses #50