fix(ui5-color-palette): stop stealing focus after keyboard navigation#13726
Open
hinzzx wants to merge 2 commits into
Open
fix(ui5-color-palette): stop stealing focus after keyboard navigation#13726hinzzx wants to merge 2 commits into
hinzzx wants to merge 2 commits into
Conversation
|
🚀 Deployed on https://pr-13726--ui5-webcomponents-preview.netlify.app |
GDamyanov
requested changes
Jul 2, 2026
| */ | ||
| _focusFirstAvailable(...candidates: Array<() => boolean>): boolean { | ||
| return candidates.some(focusAction => focusAction()); | ||
| if (!candidates.length) { |
Contributor
There was a problem hiding this comment.
What is the purpose of recursion here? Theoretically it does the same thing like candidates.some(focusAction => focusAction());
| } | ||
|
|
||
| if (this._isPrevious(e) && this._isFirstSwatch(target, this.displayedColors)) { | ||
| if (this._isPrevious(e) && swatchTarget && this._isFirstSwatch(swatchTarget, this.displayedColors)) { |
Contributor
There was a problem hiding this comment.
Since we have swatchTarget in all statements we could have early return in case !swatchTarget
|
|
||
| if (this._isNext(e) && this._isLastSwatch(target, this.recentColorsElements)) { | ||
| if (this._isNext(e) && swatchTarget && this._isLastSwatch(swatchTarget, this.recentColorsElements)) { | ||
| e.preventDefault(); |
Contributor
There was a problem hiding this comment.
Here we could have also early return in case !swatchTarget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP Not for merge yet.
Investigating the test failures in a production pipeline, as they appear stable locally (weren't stable before).