fix(ui5-flexible-column-layout): expose separator accessible name via aria-label#13776
Merged
plamenivanov91 merged 3 commits intoJul 3, 2026
Merged
Conversation
…-label The start/end resize separators (role=separator) set their accessible name via the title attribute. title is not read by VoiceOver at default verbosity, so the separators are effectively unnamed for those users, and a customer rejected title-based naming. Expose the name via aria-label instead, which is the correct accessible-name mechanism for the separator role. Updated the FCL Cypress spec to assert aria-label instead of title. Fixes UI5#13775
|
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
plamenivanov91
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13775
Problem
In
FlexibleColumnLayoutTemplate.tsx, the start and end resize separators (role="separator") set their accessible name via thetitleattribute:titleis not read by VoiceOver at default verbosity, so the separators are effectively unnamed for those users. As noted in the issue, the name should be exposed at least viaaria-label, and a customer rejectedtitle-based naming.Fix
Expose the accessible name via
aria-labelinstead oftitleon both separators.aria-labelis the correct accessible-name mechanism for theseparatorrole and is read across screen readers (VoiceOver, JAWS, NVDA). The name strings (accStartSeparatorText/accEndSeparatorText) are unchanged, so it's an attribute swap.Also updated
packages/fiori/cypress/specs/FCL.cy.tsx("tests separator acc attrs") to assertaria-labelinstead oftitleon.ui5-fcl-separator-start/.ui5-fcl-separator-end.Notes
Minimal, verifiable-by-inspection change. I updated the one spec that asserted
title; happy to keeptitleas an additional tooltip too if the team prefers exposing both, but per the issue the accessible name should come fromaria-label.🤖 Generated with Claude Code