Skip to content

feat(evalboard): treat .dmn as a deliverable kind #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SreedharAvvari merged 2 commits into from
Oct 5, 2026
Merged

feat(evalboard): treat .dmn as a deliverable kind #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6adb0d8
feat(evalboard): treat .dmn as a deliverable kind
SreedharAvvari Oct 5, 2026
ba1ac5a
test(evalboard): cover .dmn in sortArtifacts
SreedharAvvari Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions evalboard/lib/__tests__/runs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,19 @@ describe("sortArtifacts", () => {
]);
});

test("a .dmn rule ranks with the deliverables", () => {
const input = [
ref("d/artifacts/RiskRules/bindings_v2.json", "json"),
ref("d/artifacts/RiskRules/Business rule.dmn", "dmn"),
ref("d/artifacts/RiskRules/project.uiproj", "uiproj"),
];
expect(sortArtifacts(input).map((a) => a.relPath)).toEqual([
"d/artifacts/RiskRules/Business rule.dmn",
"d/artifacts/RiskRules/project.uiproj",
"d/artifacts/RiskRules/bindings_v2.json",
]);
});

test("does not mutate the input array", () => {
const input = [ref("b.txt", "txt"), ref("a.flow", "flow")];
sortArtifacts(input);
Expand Down
1 change: 1 addition & 0 deletions evalboard/lib/artifact-kinds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
export const DELIVERABLE_KINDS = new Set([
"flow",
"bpmn",
"dmn",
"uipx",
"uiproj",
"xaml",
Expand Down
Loading