fix: enforce minProperties in generated schemas - #41
Merged
damaz91 merged 2 commits intoAug 12, 2026
Merged
Conversation
…Properties injection
damaz91
approved these changes
Aug 12, 2026
damaz91
merged commit Aug 12, 2026
a50cab9
into
Universal-Commerce-Protocol:main
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
inject-schema-constraints.mjsrestores JSON Schema constraints that quicktype'stypescript-zodtarget omits, but it did not handleminProperties. The pinnedUCP schema contains two affected shapes:
The generated schemas therefore accepted both an empty
Descriptionand anempty, present
constraintsrecord:Fix: index object-level and record-level
minPropertiesconstraints andappend a Zod refinement during generation. Object schemas retain additional
properties before counting them, matching JSON Schema's default behavior.
Regression tests cover rejection of empty objects, acceptance of non-empty
objects, optional
constraints, and retention of additional description keys.Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
npm test— 50 tests passednpm run build:noEmit— passednpm run build— passedpre-commit run --all-files— passedrelease/2026-04-08produced the committedsrc/spec_generated.tsbyte-for-byte after formatting.