Skip to content

fix(rest/python): emit schema-valid shipping events - #176

Merged
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
FanouZeng-TT:fix/schema-valid-shipping-events
Aug 12, 2026
Merged

fix(rest/python): emit schema-valid shipping events#176
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
FanouZeng-TT:fix/schema-valid-shipping-events

Conversation

@FanouZeng-TT

Copy link
Copy Markdown
Contributor

Description

ship_order persisted fulfillment events with a non-schema timestamp field and omitted the required occurred_at and line_items fields. Orders returned after simulated shipping therefore failed validation against the generated Order model.

Fix: emit occurred_at and an event line-item projection containing each order line-item ID and total quantity. The integration test exercises the public simulation endpoint and validates the resulting order with Order.model_validate.

Category (Required)

  • Core Protocol
  • Governance/Contributing
  • Capability
  • Documentation
  • Infrastructure
  • Maintenance
  • SDK
  • Samples / Conformance
  • UCP Schema
  • Community Health (.github)

Related Issues

N/A

Checklist

  • I have followed the Contributing Guide and Code of Conduct.
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove the fix is effective.
  • New and existing unit tests pass locally with my changes.
  • I have included/updated the relevant JSON schemas (Core/Capability only).
  • I have regenerated Python Pydantic models (not applicable).

Screenshots / Logs (if applicable)

  • Python server test suite: 137 passed
  • pre-commit run --all-files: passed

@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:under-review and removed status:needs-triage Signal that the PR is ready for human triage labels Aug 12, 2026
@damaz91
damaz91 merged commit d8c7f9b into Universal-Commerce-Protocol:main Aug 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants