EG-4662 (11): Write async metrics exportation in AsyncMetricsReporter

[ppicom]

basically, the python SDK had no support for the async keyword (big oversimplification here, but yeah).

So, we're writing an AsyncUnleashClient . But, instead of copy and paste, what I'm doing is extracting common behavior into smaller classes that then both clients can share

Then, it so happens that some collaborators need to be different - mostly the network related ones: in this case, the reporting of metrics requires a network call; the sync one does it through requests (a sync http library) and this async one does it with another one.

Note: the HTTP is abstracted away behind the "transport" abstraction.

• feat: new AsyncMetricsReporter
• feat: wire AsyncMetricsReporter into AsyncUnleashClient
• docs: tentative update to changelog

[Copilot]

Copilot review overview

🟡 Changes recommended

Critical metrics-loss and missing client-lifecycle integration issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 · 1

Open (3)

• Restore drained metrics when send_metrics fails · New
• Integrate metrics reporter into the client lifecycle · New
• Prevent duplicate reporter tasks when start is called twice · New

What changed in this PR

Adds asynchronous metrics reporting and wires it into AsyncUnleashClient, with reporter and client integration tests.

Changes:

• Implements periodic and shutdown metrics flushing.
• Adds impact-metrics handling and async reporter construction.
• Adds reporter behavior and client wiring tests.

File	Summary	Findings
UnleashClient/​async_metrics_reporter.py	Implements async metrics export and lifecycle handling.	Critical: Drained samples may be lost when send_metrics() raises (2 votes). Moderate: start() is not idempotent (2 votes); cancellation can drop in-flight metrics during shutdown (1 vote).
UnleashClient/​clients/​async_unleash_client.py	Constructs reporter and impact-metrics collaborators.	Critical: Reporter lifecycle is not integrated into client initialization or destruction (2 votes).
tests/​unit_tests/​test_async_metrics_reporter.py	Tests reporter behavior and scheduling.	Nit: Test drops the task handle without cancelling the task (1 vote).
tests/​unit_tests/​clients/​test_async_unleash_client.py	Tests async client reporter wiring.	No findings.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[alexanto]

There are still some unresolved comments, please comment/fix/resolve those as well :)

All in all it looks solid now, approving (really this time 😅 )

[ppicom]

on it! thanks Alexandra