Fix auth-method dialog overflow with long API keys#1451
Merged
Conversation
A long unbroken key pasted as a placement prefix stretched the add-method dialog (preview line) and the connect modal (merged credential affix) past the viewport. Wrap the placement preview mid-token and truncate the merged affix inside the field.
Contributor
Cloudflare previewTorn down — the PR is closed. |
RhysSullivan
marked this pull request as ready for review
July 22, 2026 23:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long unbroken API key pasted as a placement prefix stretched the add-authentication-method dialog (and the connect modal's merged credential affix) far past the viewport.
Fix:
PlacementLinepreview wraps mid-token (wrap-anywhere) instead of forcing the dialog to the key's full width.max-w-[60%]).Regression coverage: two new steps in the
connect-modal-credential-uxselfhost scenario assert the dialog never scrolls horizontally with a 700-char pasted key, in both the add-method editor and the connect modal.Before
After
Preview wraps inside the dialog:
Merged affix truncates in the credential field:
E2E run