Register DCR clients under the bare product client_name#1456
Merged
Conversation
Some authorization servers vet the RFC 7591 client_name — Mercury rejects any name containing its own brand, which the auto-generated "Executor for Mercury MCP" always trips, failing the whole connect. The name is cosmetic, so registration now retries once with the bare product name before surfacing the failure.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | f55df60 | Jul 23 2026, 07:07 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | f55df60 | Commit Preview URL Branch Preview URL |
Jul 23 2026, 07:06 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
RhysSullivan
marked this pull request as ready for review
July 23, 2026 18:58
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Drop the "Executor for <integration>" client_name and the retry that worked around servers rejecting it. The name is cosmetic (it only labels the provider's consent screen, where the provider is already evident), and volunteering another company's brand inside it is exactly what brand-vetting servers like Mercury reject. Sending the bare name removes the failure class instead of retrying around it, and matches what the oauth-discovery DCR path already sends.
RhysSullivan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mercury's MCP authorization server vets the RFC 7591
client_nameand rejects any value containing its own brand withinvalid_client_metadata. The auto-generated "Executor for " always tripped that, failing the whole automatic connect and dropping the user into the manual app picker.The client name is cosmetic — it only labels the provider's consent screen and authorized-apps list, where the provider is already evident — so DCR now always registers under the bare product name ("Executor"). This removes the failure class entirely rather than retrying around it, and matches what the oauth-discovery DCR path already sends.
approveClientNamegate mirroring Mercury's behavior.invalid_client_metadataunchanged.