Validate OAuth discovery metadata identity (RFC 8414 / RFC 9728 / RFC 8707)#1457
Open
RhysSullivan wants to merge 3 commits into
Open
Validate OAuth discovery metadata identity (RFC 8414 / RFC 9728 / RFC 8707)#1457RhysSullivan wants to merge 3 commits into
RhysSullivan wants to merge 3 commits into
Conversation
Four scenarios against the MCP emulator's new oauth misbehavior knobs (emulate 0.13.7): issuer-mismatch rejection (RFC 8414), foreign-resource rejection (RFC 9728), client_secret_basic negotiation when the metadata omits auth methods, and honoring a server-substituted auth method (RFC 7591). The first two pass with the discovery validation on this branch; the last two stay red until auth-method negotiation is fixed.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 4dff9e5 | Commit Preview URL Branch Preview URL |
Jul 23 2026, 08:00 PM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 4dff9e5 | Jul 23 2026, 08:01 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
@executor-js/codemode-core
@executor-js/runtime-quickjs
executor
commit: |
The e2e probe-failure assertions now narrow with Predicate.isTagged and assert the typed message instead of stringifying a cast. canonicalIssuer is hoisted to module scope with the issuer-vs-resource canonicalization difference documented in one place, and the DCR resource canonicalization records why legacy raw-string rows need no backfill.
RhysSullivan
marked this pull request as ready for review
July 23, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the DCR spec audit, the three discovery-layer gaps:
issuerdoes not match the URL it was derived from is now rejected at probe time (canonical scheme/host/port/path comparison; trailing slash tolerated). Previously wrong-issuer metadata could drive the whole flow.validateResourceIndicatoris gone; a PRM discovery failure now surfaces as a typed probe error instead of silently falling back to AS-only discovery.canonicalResourceUrlkeeps query strings and trailing slashes (both identifier-significant) andregisterDynamicClientcanonicalizes the resource once before reuse-matching and persistence, so authorize/token requests carry the same canonical value the row stores.Also adds emulator-backed e2e scenarios (
e2e/scenarios/oauth-dcr-compliance.test.ts, emulate 0.13.7's new MCP oauth knobs): issuer-mismatch and foreign-resource rejection pass on this branch; two auth-method negotiation scenarios are checked in skipped (self-documenting) until the follow-up that persists the DCR response'stoken_endpoint_auth_method.