Skip to content

fix(i18n): repay KO/ES debt from the revived stale keys (FIX-I18N-DEBT-REPAYMENT-2) - #120

Merged
FullGas1 merged 2 commits into
developfrom
fix/i18n-debt-repayment-2
Aug 10, 2026
Merged

fix(i18n): repay KO/ES debt from the revived stale keys (FIX-I18N-DEBT-REPAYMENT-2)#120
FullGas1 merged 2 commits into
developfrom
fix/i18n-debt-repayment-2

Conversation

@FullGas1

@FullGas1 FullGas1 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • pytest tools/build/ - 24/24 green, unchanged
  • luac -p clean on both modified dictionaries
  • generate_i18n_dicts.ps1 dry-run reports OK on all four dictionaries
  • Manually verified zero remaining empty entries in KO/ES outside __keep_en
  • CI green on this PR

Generated with Claude Code

Summary by Sourcery

Repay remaining Korean and Spanish i18n debt for CTLD by filling previously empty translations and documenting the change.

Bug Fixes:

  • Provide Korean translations for previously empty CTLD UI and AA system strings, eliminating English fallbacks.
  • Provide Spanish translations for previously empty CTLD vehicle-category strings, eliminating English fallbacks.
  • Mark 'FARP / FOB' as non-translated (__keep_en) in KO/ES dictionaries to avoid incorrect localization.

Enhancements:

  • Document the KO/ES i18n debt repayment in the changelog and backlog, including PRD and ticket entries for FIX-I18N-DEBT-REPAYMENT-2.

…T-REPAYMENT-2)

Follow-up to FIX-I18N-STALE-COMMENT-PARSING (PR #119), which revived
56 keys wrongly marked -- STALE: in all four dictionaries. 22 KO + 7
ES entries among them were genuine debt - never translated even
before that bug. EN/FR were already complete.

Same method as FIX-I18N-DEBT-REPAYMENT: direct translation, no
ANTHROPIC_API_KEY available and the Claude Code CLI fallback can't be
invoked from a nested Claude Code session. FARP / FOB added to
__keep_en for both languages (acronym, no translatable content).

pytest tools/build/ 24/24 unchanged; generate_i18n_dicts.ps1 dry-run
reports OK on all four dictionaries. Lot:
.backlog/FIX-I18N-DEBT-REPAYMENT-2/.
@FullGas1
FullGas1 requested a review from davidp57 as a code owner August 10, 2026 12:33
@sourcery-ai

sourcery-ai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR repays remaining KO/ES i18n translation debt revived by the stale-key fix by filling all previously empty Korean and Spanish CTLD dictionary entries, marking 'FARP / FOB' as keep-English in both languages, and documenting the change in the changelog and backlog PRD/ticket files without altering any tooling.

File-Level Changes

Change Details Files
Fill remaining empty Korean CTLD i18n entries for revived AA/menus and ensure no non-keep_en KO entries remain empty.
  • Replace multiple previously empty Korean translations for CTLD crate, smoke, JTAC status, loading, missing parts, extractable troops, AA parts limit, rearm/repair messages, and category labels with Korean text.
  • Mark 'FARP / FOB' as non-translated in Korean by adding it to the __keep_en block and setting its translation to the English acronym.
  • Ensure all newly added KO translations align with existing formatting, placeholders, and newline conventions.
src/CTLD_i18n_ko.lua
Fill remaining empty Spanish CTLD i18n entries for revived AA/vehicle-category labels and mark FARP/FOB as keep-English.
  • Translate previously empty Spanish AA and vehicle-category labels (Air Defense, Aircraft, Ground Vehicles, Helicopters, Infantry, Ships) and keep 'FARP / FOB' in English in the dictionary.
  • Add 'FARP / FOB' to the Spanish __keep_en block to formalize that it should not be translated.
  • Keep all other Spanish CTLD dictionary keys and structure unchanged aside from these value updates.
src/CTLD_i18n_es.lua
Document the KO/ES i18n debt repayment lot and its scope in project docs and backlog.
  • Add an Unreleased changelog entry describing the KO/ES i18n debt repayment, number of entries translated, and test status.
  • Register FIX-I18N-DEBT-REPAYMENT-2 in the backlog README with a concise description and link to its PRD, consistent with prior backlog items.
  • Introduce a PRD document detailing problem statement, solution, scope, implementation decisions, and testing strategy for this lot.
  • Add a ticket file specifying concrete acceptance criteria for KO/ES dictionary completeness, keep_en handling, and test expectations.
CHANGELOG.md
.backlog/README.md
.backlog/FIX-I18N-DEBT-REPAYMENT-2/PRD.md
.backlog/FIX-I18N-DEBT-REPAYMENT-2/tickets/01-repay-ko-es-i18n-debt.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@FullGas1
FullGas1 merged commit 3460444 into develop Aug 10, 2026
9 checks passed
@FullGas1
FullGas1 deleted the fix/i18n-debt-repayment-2 branch August 10, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant