feat: add the complete basic Jaspr catalog - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the complete pinned A2UI v0.9 basic catalog for Jaspr, including icons, standard functions, and theme metadata.
BasicJasprCataloghas one constructor and always includes the standard 59-icon renderer, matching what its official catalog ID promises;MinimalJasprCatalogremains the lightweight option.Changes
Testing
The catalog tests exercise messages through the real processor, binder, catalog, and rendered HTML. For the icon boundary, run
dart test test/icon_tree_shaking_test.dart; for URL behavior, rundart test -p chrome test/browser/open_url_browser_test.dart. The subsequent one-constructor and published-ID corrections passed focused tests and static analysis; the local gate was not rerun at the developer's request.Gates
Gated
f2538a1againstorigin/main@ae9530c.code-review, pinnedfableunreachable, ran on the session model, passed, agent-reportedThe gate ran on
f2538a1, which is not the current headfff788d.Reviewed against the plan recorded on the issue.
Closes #17