Skip to content

fix shift click behavior in containers on legacy versions - #1351

Open
Socketlike wants to merge 4 commits into
ViaVersion:ver/26.3from
Socketlike:ver/26.3
Open

Socketlike wants to merge 4 commits into
ViaVersion:ver/26.3from
Socketlike:ver/26.3

Conversation

@Socketlike

@Socketlike Socketlike commented Oct 4, 2026 •

Copy link
Copy Markdown

fixes #1322

this is just #1323 but with the cancel mixins reimplemented into 1.15.2's MixinMultiPlayerGameMode#removeClickActions

brewing stand shift click desyncs on the legacy versions that it's possible on still since it fully relies on recipe sync on the server but i don't know how to gen the brewing stand recipes like how you guys did it for recipes-1.11.2.json

@Socketlike
Socketlike requested a review from a team October 4, 2026 10:40
@florianreuth

Copy link
Copy Markdown
Member

@Socketlike I refactored the code a bit to move the registries into a file + the if else chain spam into a dedicated method. Could you verify that your behavior still works? @RaphiMC Could you do a last review of the current state?

@florianreuth

Copy link
Copy Markdown
Member

Was the unregister of v1_6_1/MixinAbstractContainerScreen on purpose? I removed the file now, but would be good to confirm this.

@Socketlike

Copy link
Copy Markdown
Author

Was the unregister of v1_6_1/MixinAbstractContainerScreen on purpose? I removed the file now, but would be good to confirm this.

it was on purpose yes
it was one of the mixins that disabled shift clicking <= 1.6.1

@Socketlike

Copy link
Copy Markdown
Author

@Socketlike I refactored the code a bit to move the registries into a file + the if else chain spam into a dedicated method. Could you verify that your behavior still works? @RaphiMC Could you do a last review of the current state?

everything still works.. except for the brewing stand
i still need help with making the legacy recipes for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a toggle for injection.mixin.features.v1_6_1.MixinAbstractContainerScreen

2 participants