fix: skill changelog records reviewer name, not status - #24
Open
cestercian wants to merge 1 commit into
Open
cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
land() passed proposal status into append_changelog instead of the sealed reviewer identity; changelog entries now record the approver. Co-authored-by: Cestercian <yashafaid@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Landing an approved skill proposal wrote changelog lines as
(approved by approved)becauseland()passedstr(proposal.status)intoapproved_byinstead of the reviewer identity.This loads the reviewer from proposal frontmatter onto
StoredProposaland passes that through on land, with a regression test that the changelog line contains the reviewer name rather than the status verb.Fixes #11
Test plan
test_land_changelog_records_reviewer_not_status