fix(Odiff): this.hddService.generateNewImage is not a function

[mokhtardziri]

Summary by CodeRabbit

• Improvements

  • Improved image handling for saving, reading, copying, and deleting files.
  • Added validation to prevent invalid or unsafe image paths.
  • Improved handling of missing images and image data retrieval.
  • Enhanced reliability of image comparisons and related services.

• Tests

  • Updated test coverage and setup for improved service reliability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 17b00e9e-22e4-4c0b-af90-0fca1ea45634

📥 Commits

Reviewing files that changed from the base of the PR and between d689cbc and 42c1de4.

📒 Files selected for processing (1)

• src/static/hdd/hdd.service.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

HddService now uses asynchronous filesystem operations, validates image paths, and supports buffer retrieval and image copying. StaticModule exports the service, and OdiffService receives it through dependency injection with an updated test mock.

Changes

HddService and OdiffService integration

Layer / File(s)	Summary
HddService filesystem operations src/static/hdd/hdd.service.ts	HddService validates image paths and uses promise-based APIs for saving, reading, copying, and deleting images. Image decoding is separated from buffer retrieval.
HddService module wiring src/static/static.module.ts	StaticModule registers and exports HddService.
OdiffService injection integration src/compare/libs/odiff/odiff.service.ts, src/compare/libs/odiff/odiff.service.spec.ts	OdiffService injects HddService directly. The test module provides a mocked HddService and uses updated relative imports.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 42c1d

The PR fixes HDD-backed image comparison wiring without introducing an actionable correctness or security risk; no merge-blocking risk remains after normal checks and review.

Suggested reviewers: pashidlos, ngervasyuk

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing the OdiffService dependency on HddService that caused generateNewImage to be unavailable.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pashidlos]

LGTM!