Gate the PTM legend callout on PTM data presence - #107
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PTM legend now appears only when PTM nodes exist. Package metadata updates the version from 1.5.1 to 1.5.2. ChangesPTM legend release
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #107 +/- ##
=======================================
Coverage 57.56% 57.56%
=======================================
Files 13 13
Lines 1527 1527
=======================================
Hits 879 879
Misses 648 648 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Motivation and Context
The PTM legend callout was displayed even when a network contained no PTM data, creating misleading UI content. The legend is now gated on the presence of PTM nodes, and the package version is bumped to 1.5.2.
Changes
inst/htmlwidgets/cytoscapeNetwork.js:DESCRIPTION:1.5.1to1.5.2.Unit Tests
Coding Guidelines