Skip to content

Gate the PTM legend callout on PTM data presence - #107

Merged
tonywu1999 merged 1 commit into
develfrom
MSstatsBioNet/work/20260727_gate_ptm_legend_callout
Jul 30, 2026
Merged

Gate the PTM legend callout on PTM data presence#107
tonywu1999 merged 1 commit into
develfrom
MSstatsBioNet/work/20260727_gate_ptm_legend_callout

Conversation

@swaraj-neu

@swaraj-neu swaraj-neu commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

The PTM legend callout was displayed even when a network contained no PTM data, creating misleading UI content. The legend is now gated on the presence of PTM nodes, and the package version is bumped to 1.5.2.

Changes

  • Updated inst/htmlwidgets/cytoscapeNetwork.js:
    • Detects whether PTM nodes are present.
    • Displays the “PTM info” legend message only when PTM data exists.
  • Updated DESCRIPTION:
    • Bumped package version from 1.5.1 to 1.5.2.

Unit Tests

  • No unit tests were added or modified.

Coding Guidelines

  • No coding guideline violations were identified.

@swaraj-neu
swaraj-neu requested a review from tonywu1999 July 28, 2026 05:11
@swaraj-neu swaraj-neu self-assigned this Jul 28, 2026
@swaraj-neu swaraj-neu added the bug Something isn't working label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6abbf9b6-2cd4-47bc-a8a8-c8e579ec652c

📥 Commits

Reviewing files that changed from the base of the PR and between 0b6f880 and 36710f4.

📒 Files selected for processing (2)
  • DESCRIPTION
  • inst/htmlwidgets/cytoscapeNetwork.js

📝 Walkthrough

Walkthrough

The PTM legend now appears only when PTM nodes exist. Package metadata updates the version from 1.5.1 to 1.5.2.

Changes

PTM legend release

Layer / File(s) Summary
Conditional PTM legend
inst/htmlwidgets/cytoscapeNetwork.js
buildLegend detects PTM nodes and conditionally renders the PTM information panel.
Package version update
DESCRIPTION
The package version is updated from 1.5.1 to 1.5.2.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: tonywu1999

Poem

A rabbit hops through legends bright,
Hiding PTM notes when none are in sight.
The version leaf turns fresh and new,
From 1.5.1 to 1.5.2.
“Neat!” says the bunny, “A tidy view!”

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing all required template sections, including motivation, changes, testing, and checklist. Add the template sections with motivation/context, bullet-point changes, testing notes, and the checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: conditionally showing the PTM legend only when PTM data exists.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MSstatsBioNet/work/20260727_gate_ptm_legend_callout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.56%. Comparing base (e25917e) to head (36710f4).
⚠️ Report is 2 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #107   +/-   ##
=======================================
  Coverage   57.56%   57.56%           
=======================================
  Files          13       13           
  Lines        1527     1527           
=======================================
  Hits          879      879           
  Misses        648      648           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tonywu1999
tonywu1999 merged commit 7d4310d into devel Jul 30, 2026
4 checks passed
@tonywu1999
tonywu1999 deleted the MSstatsBioNet/work/20260727_gate_ptm_legend_callout branch July 30, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants