Restore packaged desktop preload bridge - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Restores the Electron desktop host bridge in packaged builds, so project creation and project-backed saving are available again.
Root cause
The Beta 2 preload attempted to load
package.jsonwith a localrequire()before exposingwindow.parlynHost. Electron's sandboxed preload environment rejects that import and aborted the entire bridge.Changes
app.getVersion()v0.5.0-beta.3replacement prerelease and acceptance checklistVerification
npm run check✅Closes #25. Continues #23.