Return structured JSON for bounded cursor validation errors - #5424
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounded find cursor failures previously wrote human diagnostics to stderr even when JSON was explicitly selected. The shared bounded-response validator now emits versioned stdout errors with command identity, typed cursor categories and recovery hints. Human diagnostics and standalone count continuation retain their existing behavior.
Validation errors honor UTF-8 byte limits, including the final newline. If the complete error cannot fit,
E028_RESPONSE_BUDGET_TOO_SMALLreports the measured minimum and preserves the originalvalidation_error. Shared-wrapper regression assertions, including symbols NDJSON cursor validation, require structured machine output for malformed, mismatched and stale cursors with empty stderr.Fixes #5412
Validation
git diff --checkpassed.dotnet run --project tools/CodeIndex.Changelog -- checkpassed.origin/main..HEAD, including a follow-up review of the CI test correction: No blocking/actionable issues found.Documentation and changelog
docs/find-scan-controls.mdandTESTING_GUIDE.md.changelog.d/unreleased/5412.fixed.md;CHANGELOG.mdis unchanged.Follow-ups
Tracked separately: #5423.