Fix cancellation propagation through plain search - #5428
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain search previously discarded the caller's cancellation token, so even a pre-cancelled strict count query could return a normal result. Carry the token through the execution plan and database setup, apply scoped reader cancellation and SQLite interruption, and preserve cancellation through managed classification, source loading and aggregation before output.
Regression coverage exercises pre-cancelled rows/counts/aggregations and cancellation inside real SQLite statements through direct calls, the CLI, and serial/parallel batches. It also checks managed C#/Python classification, reader token restoration, and cancellation at the first/last aggregation group. FTS hits, exact misses and
--allow-partialretain interruption precedence. Update both languages inUSER_GUIDE.mdandTESTING_GUIDE.md, with changelog fragmentchangelog.d/unreleased/5421.fixed.md.Fixes #5421
Validation
make lint: passed.dotnet build: passed, no warnings or errors.dotnet run --project tools/CodeIndex.Changelog -- check: passed.git diff --check: passed.No blocking/actionable issues found.Follow-up
#5427