Repository navigation
Preserve slash-separated CLI flags in batch recovery hints - #5429
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch child-error sanitization changed
--limit/--max-json-bytesinto--limit<path>, corrupting cursor recovery hints. Preserve complete slash-separated public CLI option lists using the flag catalog while retaining filesystem-path and secret-value redaction.Add parser controls for punctuation, aliases, POSIX/Windows paths, unknown option-like names and path prefixes/suffixes, plus standalone/serial/parallel malformed-cursor hint parity.
Validation
dotnet build -p:UseSharedCompilation=false— passed, no warnings or errors.--limit/--max-json-bytes.dotnet run --project tools/CodeIndex.Changelog -- check— passed (18 fragments).git diff --check— passed.Documentation
Updated both English and Japanese sections of
USER_GUIDE.mdandTESTING_GUIDE.md.Changelog fragment:
changelog.d/unreleased/5423.fixed.md.Review
Codex adversarial review completed in two rounds. Fixed the first-round P2 finding about private filename suffixes after closing punctuation and added regression controls. Final result:
No blocking/actionable issues found.No out-of-scope follow-up issues were identified. Agent instruction files were not changed.
Fixes #5423