ci: use repository variables for shared CI/CD config - #131
Open
sukhada wants to merge 1 commit into
Open
Conversation
Replace hardcoded env values in ci-cd.yml with repository variables (vars.*). This allows the same values to be shared across multiple workflow files without duplication and drift. Repository variables to set in GitHub Settings → Variables: GCP_REGION, GAR_REGISTRY, GKE_CLUSTER, GKE_LOCATION, STAGING_NAMESPACE, STAGING_DEPLOYMENT, WIF_PROVIDER, WIF_SERVICE_ACCOUNT Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
envblock inci-cd.ymlwith repository variables (vars.*). This eliminates duplication across workflow files — the seed-staging workflow (#130) and any future workflows can reference the same variables without copying values.Before
After
Prerequisites
Most repository variables are already required by #130. The only new variable this PR needs:
GAR_REGISTRYus-west1-docker.pkg.dev/spoke-407503/spoke/coreAll other variables (
GCP_REGION,GKE_CLUSTER,GKE_LOCATION,STAGING_NAMESPACE,STAGING_DEPLOYMENT,WIF_PROVIDER,WIF_SERVICE_ACCOUNT) are already listed as prerequisites in #130.Test plan
GAR_REGISTRYrepository variable in GitHub Settings → Variables → Actions🤖 Generated with Claude Code