refactor(src/lib): 1a - remove dead code - #132
Draft
sukhada wants to merge 1 commit into
Draft
Conversation
sukhada
force-pushed
the
claude/lib-cleanup-1a
branch
from
March 21, 2026 23:10
e654bde to
f4fdbcf
Compare
Dead code identified via ts-prune + manual grep verification. Deletions: - dst-helper.js + test: unused outside its own test, hand-rolls DST detection that luxon does natively - js-types.ts: misleading types (TruthyString includes falsy values), inlined into the 2 consuming files with better names - __mocks__/ directory: redundant with jest.mock() auto-mocking - getInteractionTree: never imported outside barrel - getDisplayPhoneNumber: never imported outside barrel - getCommonZipRanges: never imported outside barrel - timezonecomplete dependency: only consumer was dst-helper Unexported (internal-only): - getHighestRole: only used by hasRole() within permissions.ts - downloadFromUrl: only used by withTempDownload() within utils.ts Removed unused lodash import from index.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sukhada
force-pushed
the
claude/lib-cleanup-1a
branch
from
March 21, 2026 23:12
f4fdbcf to
156e0d9
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1A of the modernization effort scoped specifically to the src/lib directory. Dead code identified via
ts-prune+ manual grep verification across all production code (excluding tests).Deletions (-214 lines):
dst-helper.js+ its test — unused outside its own test; hand-rolls DST detection that luxon does nativelyjs-types.ts— misleading types (TruthyStringincludes falsy values); inlined into the 2 consuming files with better names__mocks__/directory — redundant;jest.mock()auto-mocks without needing manual mock filesgetInteractionTree— never imported outside barrelgetDisplayPhoneNumber— never imported outside barrelgetCommonZipRanges— never imported outside barreltimezonecompletedependency — only consumer wasdst-helper.jsUnexported (internal-only):
getHighestRole— only used byhasRole()withinpermissions.tsdownloadFromUrl— only used bywithTempDownload()withinutils.tsVerification method:
ts-prune --project tsconfig.jsonflagged candidates. Each was then verified withgrepacross the full codebase (excluding test/spec files and barrel re-exports) to confirm zero production consumers.Test plan
src/lib/tests pass🤖 Generated with Claude Code