test(src/lib): 2a - move zip-format tests to co-located spec file - #134
Draft
sukhada wants to merge 1 commit into
Draft
test(src/lib): 2a - move zip-format tests to co-located spec file#134sukhada wants to merge 1 commit into
sukhada wants to merge 1 commit into
Conversation
2 tasks
Move __test__/lib/zip-format.test.js to src/lib/zip-format.spec.ts so it runs in CI (which only runs src/**/*). Two tests are skipped with TODO comments: they document correct expected behavior but fail due to a known bug in getFormattedZip where the 4-digit regex matches substrings. These tests were already failing but went unnoticed because __test__/lib/ was not in CI. Fix tracked for PR 4. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sukhada
force-pushed
the
claude/lib-cleanup-2a
branch
from
March 21, 2026 23:54
2daac72 to
9d3f8d7
Compare
sukhada
changed the title
sukhada
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2A of the src/lib/ modernization. Moves the only remaining test from
__test__/lib/to a co-located spec file insrc/lib/.This is a pure move with one import path change. The test content is unchanged (modernization happens in PR 2b).
Discovery: Two tests are now skipped — they document correct expected behavior but were silently failing because
__test__/lib/was never run in CI. The tests expectgetFormattedZip('a2345-abcd')to return falsy, but the source returns'0a2345-abcd'due to a regex bug. Fix tracked for PR 4.Stacked on: #133
Test plan
Generated with Claude Code